-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1619272: fix explode outer parameter type casting causing dynamic table creation failure #2154
SNOW-1619272: fix explode outer parameter type casting causing dynamic table creation failure #2154
Conversation
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
1 similar comment
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since we also use the same cast when analyzing FunctionExpression
ccb02af
to
63acb6b
Compare
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
…hen-used-with-explode
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment otherwise LGTM
…hen-used-with-explode
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
daily precommit running: https://github.com/snowflakedb/snowpark-python/actions/runs/10620281367 |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1619272
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
backend function FLATTEN_CONSTRUCT doesn't accept
False::BOOLEAN
but acceptFalse
.to bypass the issue, we don't cast type if the input value is of boolean type on the client side